Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POC/adaptive cards #814

Merged

Conversation

Sanjuice
Copy link

@Sanjuice Sanjuice commented Oct 29, 2024

This is a proof of concept for adaptive cards using javascript.

@Sanjuice Sanjuice requested a review from a team as a code owner October 29, 2024 20:28
@Sanjuice Sanjuice changed the title Poc/adaptive cards POC/adaptive cards Oct 29, 2024
Copy link

codecov bot commented Oct 30, 2024

Codecov Report

Attention: Patch coverage is 1.98675% with 148 lines in your changes missing coverage. Please review.

Project coverage is 67.67%. Comparing base (502fb1d) to head (8211d10).
Report is 16 commits behind head on main.

Files with missing lines Patch % Lines
src/shell/dotnet/Shell/Layout/LayoutManager.cs 0.00% 118 Missing ⚠️
src/shell/dotnet/Shell/MainWindow.xaml.cs 0.00% 18 Missing ⚠️
.../shell/dotnet/Shell/Layout/MainWindowParameters.cs 0.00% 5 Missing ⚠️
src/shell/dotnet/Shell/MainWindow.xaml 0.00% 3 Missing ⚠️
src/shell/dotnet/Shell/WebContentPane.cs 0.00% 3 Missing ⚠️
src/shell/dotnet/Shell/App.xaml.cs 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #814      +/-   ##
==========================================
- Coverage   68.85%   67.67%   -1.18%     
==========================================
  Files         300      300              
  Lines        8871     8982     +111     
  Branches      921     1032     +111     
==========================================
- Hits         6108     6079      -29     
- Misses       2543     2686     +143     
+ Partials      220      217       -3     
Files with missing lines Coverage Δ
...mposeUI.LayoutPersistence/FileLayoutPersistence.cs 92.85% <100.00%> (-0.70%) ⬇️
src/shell/dotnet/Shell/App.xaml.cs 0.00% <0.00%> (ø)
src/shell/dotnet/Shell/MainWindow.xaml 0.00% <0.00%> (ø)
src/shell/dotnet/Shell/WebContentPane.cs 0.00% <0.00%> (ø)
.../shell/dotnet/Shell/Layout/MainWindowParameters.cs 0.00% <0.00%> (ø)
src/shell/dotnet/Shell/MainWindow.xaml.cs 0.00% <0.00%> (ø)
src/shell/dotnet/Shell/Layout/LayoutManager.cs 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

examples/adaptive-cards/rollup.config.js Outdated Show resolved Hide resolved
examples/adaptive-cards/app.js Outdated Show resolved Hide resolved
examples/adaptive-cards/README.md Show resolved Hide resolved
@Sanjuice Sanjuice requested a review from kruplm October 31, 2024 20:02
package.json Outdated Show resolved Hide resolved
examples/adaptive-cards/README.md Outdated Show resolved Hide resolved
@lilla28
Copy link
Contributor

lilla28 commented Nov 5, 2024

Can you please also squash your commits as well? as they are mostly belongs together (creating adaptive card poc for JS)

@Sanjuice Sanjuice requested a review from lilla28 November 5, 2024 22:48
@kruplm kruplm changed the base branch from main to prototypes/adaptive-cards November 6, 2024 15:30
Copy link
Contributor

@kruplm kruplm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fhubi fhubi self-requested a review November 13, 2024 13:32
@kruplm kruplm merged commit db708ec into morganstanley:prototypes/adaptive-cards Nov 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants